chore: update types from deps#479
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates route typing and path patterns to align with updated dependency types (notably Express 5 / path-to-regexp), plus a small robustness tweak in the W3C groups update script.
Changes:
- Adjust Express route path patterns to use optional-segment grouping (e.g.,
"/meta{/:field}","/groups{/:shortname}{/:type}"). - Tighten TypeScript typings for
req.paramsin several route handlers. - Add defensive handling in the W3C groups list update script when flattening TF members.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/update-w3c-groups-list.ts | Makes TF member flattening and iteration more defensive when producing the groups list JSON. |
| routes/xref/index.ts | Updates /meta route pattern for optional segment handling under updated routing deps. |
| routes/w3c/index.ts | Updates /groups route pattern to use optional segment grouping. |
| routes/w3c/group.ts | Refines Express Request param typing for shortname/type. |
| routes/github/contributors.ts | Refines Express Request param typing for org/repo. |
| routes/github/commits.ts | Refines Express Request param typing for org/repo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/d972ccea-f5eb-4212-b475-b3858cf8895e Co-authored-by: marcoscaceres <870154+marcoscaceres@users.noreply.github.com>
sidvishnoi
reviewed
Apr 14, 2026
Collaborator
Author
|
@copilot, can you apply @sidvishnoi's suggestions. They all seem reasonable. |
Contributor
Done in 61ce264 — applied all three of @sidvishnoi's suggestions. |
sidvishnoi
reviewed
Apr 14, 2026
Collaborator
Author
|
@copilot a few more suggestions from Sid. Can you address them? |
Contributor
sidvishnoi
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update various types...